linux-kernel - Re: [PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <162fe71f-e190-3511-6b06-35efdbc8573f@mleia.com>
Date:   Wed, 21 Sep 2016 13:17:44 +0300
From:   Vladimir Zapolskiy <vz@...ia.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, mturquette@...libre.com,
        sboyd@...eaurora.org, slemieux.tyco@...il.com
Cc:     linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: nxp: clk-lpc32xx: Unmap region obtained by of_iomap

On 20.09.2016 13:54, Arvind Yadav wrote:
> From: Arvind Yadav <arvind.yadav.cs@...il.com>
> 
> Free memory mapping, if lpc32xx_clk_init is not successful.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/clk/nxp/clk-lpc32xx.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/nxp/clk-lpc32xx.c b/drivers/clk/nxp/clk-lpc32xx.c
> index 90d740a..34c9735 100644
> --- a/drivers/clk/nxp/clk-lpc32xx.c
> +++ b/drivers/clk/nxp/clk-lpc32xx.c
> @@ -1513,6 +1513,7 @@ static void __init lpc32xx_clk_init(struct device_node *np)
>  	if (IS_ERR(clk_regmap)) {
>  		pr_err("failed to regmap system control block: %ld\n",
>  			PTR_ERR(clk_regmap));
> +		iounmap(base);
>  		return;
>  	}
>  
> 

Acked-by: Vladimir Zapolskiy <vz@...ia.com>

Thank you for the patch.

--
With best wishes,
Vladimir