linux-kernel - [PATCH -next] soc: mediatek: PMIC wrap: fix missing clk_disable_unprepare() on error in pwrap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1474470511-2458-1-git-send-email-weiyj.lk@gmail.com>
Date:   Wed, 21 Sep 2016 15:08:31 +0000
From:   Wei Yongjun <weiyj.lk@...il.com>
To:     Matthias Brugger <matthias.bgg@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        John Crispin <blogic@...nwrt.org>,
        Henry Chen <henryc.chen@...iatek.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Daniel Kurtz <djkurtz@...omium.org>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: [PATCH -next] soc: mediatek: PMIC wrap: fix missing clk_disable_unprepare() on error in pwrap_probe()

From: Wei Yongjun <weiyongjun1@...wei.com>

Fix the missing clk_disable_unprepare() before return
from pwrap_probe() in the error handling case.

Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
---
 drivers/soc/mediatek/mtk-pmic-wrap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
index a5f1093..4da3bb2 100644
--- a/drivers/soc/mediatek/mtk-pmic-wrap.c
+++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
@@ -1200,7 +1200,8 @@ static int pwrap_probe(struct platform_device *pdev)
 
 	if (!(pwrap_readl(wrp, PWRAP_WACS2_RDATA) & PWRAP_STATE_INIT_DONE0)) {
 		dev_dbg(wrp->dev, "initialization isn't finished\n");
-		return -ENODEV;
+		ret = -ENODEV;
+		goto err_out2;
 	}
 
 	/* Initialize watchdog, may not be done by the bootloader */