linux-kernel - Re: [PATCH 02/61] perf tools: Remove superfluous initialization of weight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160921151519.GH4973@kernel.org>
Date:   Wed, 21 Sep 2016 12:15:19 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Don Zickus <dzickus@...hat.com>, Joe Mario <jmario@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 02/61] perf tools: Remove superfluous initialization of
 weight

Em Mon, Sep 19, 2016 at 03:09:11PM +0200, Jiri Olsa escreveu:
> Removing superfluous initialization of weight,
> it's already set to 0 via memset.

Thanks, applied.
 
> Link: http://lkml.kernel.org/n/tip-1fmf7sw8p16zwl9q6au10t7c@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  tools/perf/util/evsel.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 21fd573106ed..f3225a2e6eee 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -1728,7 +1728,6 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
>  	data->cpu = data->pid = data->tid = -1;
>  	data->stream_id = data->id = data->time = -1ULL;
>  	data->period = evsel->attr.sample_period;
> -	data->weight = 0;
>  	data->cpumode = event->header.misc & PERF_RECORD_MISC_CPUMODE_MASK;
>  
>  	if (event->header.type != PERF_RECORD_SAMPLE) {
> @@ -1935,7 +1934,6 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
>  		}
>  	}
>  
> -	data->weight = 0;
>  	if (type & PERF_SAMPLE_WEIGHT) {
>  		OVERFLOW_CHECK_u64(array);
>  		data->weight = *array;
> -- 
> 2.7.4