linux-kernel - Re: [PATCH 05/61] perf tools: Introduce c2c_decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160921153245.GB28272@krava>
Date:   Wed, 21 Sep 2016 17:32:45 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Don Zickus <dzickus@...hat.com>
Cc:     Stanislav Ievlev <stanislav.ievlev@...il.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Joe Mario <jmario@...hat.com>, Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Namhyung Kim <namhyung@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 05/61] perf tools: Introduce c2c_decode_stats function

On Wed, Sep 21, 2016 at 11:16:26AM -0400, Don Zickus wrote:
> On Wed, Sep 21, 2016 at 11:18:29AM +0200, Jiri Olsa wrote:
> > On Wed, Sep 21, 2016 at 09:08:40AM +0000, Stanislav Ievlev wrote:
> > > Hi, Jiri!
> > > 
> > > Why are you not using unsigned integer for counters in c2c_stats structure?
> > 
> > hi,
> > never really thought of that, because that's one of the original
> > patches I could take almost untouched.. so no real reason ;-)
> 
> Hi Jirka,
> 
> I can't recall the reason Dick and myself started that way.  I think it
> makes sense to use u32 here.  So I am fine with it. :-)

ok, will change

thanks,
jirka