linux-kernel - [PATCH] clocksource: tegra20_timer: Unmap region obtained by of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2016 21:23:35 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     daniel.lezcano@...aro.org, tglx@...utronix.de,
        swarren@...dotorg.org, thierry.reding@...il.com, gnurou@...il.com
Cc:     linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: [PATCH] clocksource: tegra20_timer: Unmap region obtained by of_iomap

Free memory mapping, if tegra20_init_timer is not successful.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
---
 drivers/clocksource/tegra20_timer.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/clocksource/tegra20_timer.c b/drivers/clocksource/tegra20_timer.c
index f960891..adcd7f4 100644
--- a/drivers/clocksource/tegra20_timer.c
+++ b/drivers/clocksource/tegra20_timer.c
@@ -180,6 +180,7 @@ static int __init tegra20_init_timer(struct device_node *np)
 	tegra_timer_irq.irq = irq_of_parse_and_map(np, 2);
 	if (tegra_timer_irq.irq <= 0) {
 		pr_err("Failed to map timer IRQ\n");
+		iounmap(timer_reg_base);
 		return -EINVAL;
 	}
 
@@ -216,6 +217,7 @@ static int __init tegra20_init_timer(struct device_node *np)
 				    clocksource_mmio_readl_up);
 	if (ret) {
 		pr_err("Failed to register clocksource\n");
+		iounmap(timer_reg_base);
 		return ret;
 	}
 
@@ -227,6 +229,7 @@ static int __init tegra20_init_timer(struct device_node *np)
 	ret = setup_irq(tegra_timer_irq.irq, &tegra_timer_irq);
 	if (ret) {
 		pr_err("Failed to register timer IRQ: %d\n", ret);
+		iounmap(timer_reg_base);
 		return ret;
 	}
 
-- 
2.7.4