linux-kernel - Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1474428588.10249.0.camel@mtksdaap41>
Date:   Wed, 21 Sep 2016 11:29:48 +0800
From:   James Liao <jamesjj.liao@...iatek.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
CC:     <mturquette@...libre.com>, <sboyd@...eaurora.org>,
        <matthias.bgg@...il.com>, <djkurtz@...omium.org>,
        <p.zabel@...gutronix.de>, <yingjoe.chen@...iatek.com>,
        <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] clk: mediatek: clk-mt8173: Unmap region obtained by
 of_iomap

On Tue, 2016-09-20 at 14:00 +0530, Arvind Yadav wrote:
> From: Arvind Yadav <arvind.yadav.cs@...il.com>
> 
> Free memory mapping, if init is not successful.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Reviewed-by: James Liao <jamesjj.liao@...iatek.com>

> ---
>  drivers/clk/mediatek/clk-mt8173.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/mediatek/clk-mt8173.c b/drivers/clk/mediatek/clk-mt8173.c
> index 10c9860..0ac3aee 100644
> --- a/drivers/clk/mediatek/clk-mt8173.c
> +++ b/drivers/clk/mediatek/clk-mt8173.c
> @@ -1074,8 +1074,10 @@ static void __init mtk_apmixedsys_init(struct device_node *node)
>  	}
>  
>  	mt8173_pll_clk_data = clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
> -	if (!clk_data)
> +	if (!clk_data) {
> +		iounmap(base);
>  		return;
> +	}
>  
>  	mtk_clk_register_plls(node, plls, ARRAY_SIZE(plls), clk_data);
>