linux-kernel - Re: [PATCH] usb: musb: fix error handling message in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2016 15:46:35 -0500
From:   Bin Liu <b-liu@...com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        David Lechner <david@...hnology.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: musb: fix error handling message in probe

Hi,

On Sat, Sep 17, 2016 at 12:21:25AM +0200, Arnd Bergmann wrote:
> We print an error message when platform_device_register_full()
> fails, but the initialization of the argument has been removed,
> as shown in this warning:
> 
> drivers/usb/musb/da8xx.c: In function 'da8xx_probe':
> drivers/usb/musb/da8xx.c:521:3: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> This modifies the function to assign the return code before
> checking it, and does uses the same method in the check for
> usb_phy_generic_register() as well.
> 
> Fixes: 947c49afe41f ("usb: musb: da8xx: Remove mach code")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied. Thanks.
(Added 'da8xx:' prefix in the commit subject)

Regards,
-Bin.