linux-kernel - Re: [PATCH v3 1/2] staging: ion: Fix a coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7eee403-0aba-e91c-6646-45c8b73c86a0@redhat.com>
Date:   Thu, 22 Sep 2016 13:15:02 -0700
From:   Laura Abbott <labbott@...hat.com>
To:     Antti Keränen <detegr@...il.com>
Cc:     sumit.semwal@...aro.org, gregkh@...uxfoundation.org,
        arve@...roid.com, riandrews@...roid.com, bhaktipriya96@...il.com,
        yudongbin@...ilicon.com, puck.chen@...ilicon.com,
        weiyongjun1@...wei.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] staging: ion: Fix a coding style issue

On 09/22/2016 08:59 AM, Antti Keränen wrote:
> Remove unnecessary braces surrounding a single statement block
>

In the future, when sending different versions of a patch please
give a short summary of what's changed. I think this is just
a resend from v2 with more reviewers added but I'm not 100%
sure.

> Signed-off-by: Antti Keränen <detegr@...il.com>
> ---

You can put your summary right here between the --- and the
diffstat.

>  drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> index 659aa71..bd45151 100644
> --- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> +++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> @@ -82,9 +82,9 @@ static int hi6220_ion_remove(struct platform_device *pdev)
>
>  	ipdev = platform_get_drvdata(pdev);
>
> -	for (i = 0; i < ipdev->data->nr; i++) {
> +	for (i = 0; i < ipdev->data->nr; i++)
>  		ion_heap_destroy(ipdev->heaps[i]);
> -	}
> +
>  	ion_destroy_platform_data(ipdev->data);
>  	ion_device_destroy(ipdev->idev);
>
>

The patch looks fine though so assuming nothing else has
changed

Acked-by: Laura Abbott <labbott@...hat.com>