linux-kernel - Re: GPU-DRM-QXL: Move three assignments in qxl_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Sep 2016 22:24:22 +0200
From:   Gerd Hoffmann <kraxel@...hat.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        dri-devel@...ts.freedesktop.org,
        Julia Lawall <julia.lawall@...6.fr>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Tejun Heo <tj@...nel.org>, Thierry Reding <treding@...dia.com>
Subject: Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

On Do, 2016-09-22 at 19:16 +0200, SF Markus Elfring wrote:
> > For starters make sure the patches land actually on the list.
> 
> How do you think about to take another look at this update suggestion
> also by the usual archive interfaces?
> 
> * https://patchwork.kernel.org/patch/9344521/
> 
> * https://lkml.kernel.org/r/<f7eb26ad-39be-2918-627b-5f4981d07808@...rs.sourceforge.net>

I fail to see the point in this change.  On init failure qdev will be
released anyway, and whenever the fields are initialized or not when
kfree() is called doesn't matter at all.

> > Only the cover letter arrived here.
> 
> Would you like to clarify any more technical difficulties around
> the desired message exchange?

Hmm, not sure what happened.  According to the kernel.org link the patch
has been sent to dri-devel (where I'm subscribed), but the patch never
landed in by mailbox for some reason.

cheers,
  Gerd