linux-kernel - Re: [PATCH 1/2] jump_labels: Add API to deal with keys embedded in structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160922074737.GU5008@twins.programming.kicks-ass.net>
Date:   Thu, 22 Sep 2016 09:47:37 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Christoffer Dall <christoffer.dall@...aro.org>
Cc:     Marc Zyngier <marc.zyngier@....com>, linux-kernel@...r.kernel.org,
        Jason Baron <jbaron@...mai.com>,
        Jonathan Corbet <corbet@....net>,
        Vladimir Murzin <vladimir.murzin@....com>,
        Catalin Marinas <catalin.marinas@....com>
Subject: Re: [PATCH 1/2] jump_labels: Add API to deal with keys embedded in
 structures

On Tue, Sep 20, 2016 at 02:54:01PM +0200, Christoffer Dall wrote:
> On Tue, Sep 20, 2016 at 02:42:58PM +0200, Peter Zijlstra wrote:
> > 'struct static_key' should indeed not be used and is deprecated. 'struct
> > static_key_{true,false}' however should be fine.
> 
> ah, ok, didn't realize this, especially since static_key_false() is also
> listed as deprecated ;)

Yeah, that's one of the horribly badly named things we wants to get rid
of :-) But note, its a function not a type.


> > Part of the problem is naming, everything using 'struct static_key' has
> > _insane_ names and the API is utterly confusing. The other part is that
> > the new 2 type API simply has more functionality.
> 
> right, ok.  As long as you're happy with slightly increased use of
> directly embeddeing struct static_key_{true,false}, we're good.
> 
> Sorry for both if I encouraged confusion here.

No problem, jump_labels have been cursed with confusion.