linux-kernel - Re: [PATCH 1/2] NFSD: notifiers registration cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84473086-ba97-64c9-ae4d-40bbe82eeef6@virtuozzo.com>
Date:   Thu, 22 Sep 2016 11:35:31 +0300
From:   Vasily Averin <vvs@...tuozzo.com>
To:     Jeff Layton <jlayton@...hat.com>, linux-kernel@...r.kernel.org,
        linux-nfs@...r.kernel.org
Cc:     "J. Bruce Fields" <bfields@...ldses.org>,
        Scott Mayhew <smayhew@...hat.com>
Subject: Re: [PATCH 1/2] NFSD: notifiers registration cleanup

On 21.09.2016 16:20, Jeff Layton wrote:
> Good catch. I'm not very fond of the refcounting this here but it
> should
> serve the purpose and I don't have anything better to suggest. FWIW, I
> think the nfsd_mutex is held during all of these operations so we
> probably don't need atomics for the refcount.

I've copied idea from netfilters,
look at using of masquerade_notifier_refcount

Perhaps someday in future we'll replace all such cases by some common primitive.