linux-kernel - Re: [PATCH] docs: Remove space-before-label guidance from CodingStyle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160922112758.6fbfeffe@endymion>
Date:   Thu, 22 Sep 2016 11:27:58 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Jonathan Corbet <corbet@....net>
Cc:     LKML <linux-kernel@...r.kernel.org>, linux-doc@...r.kernel.org,
        Christian Borntraeger <borntraeger@...ibm.com>
Subject: Re: [PATCH] docs: Remove space-before-label guidance from
 CodingStyle

Hi Jonathan,

On Wed, 21 Sep 2016 15:54:01 -0600, Jonathan Corbet wrote:
> Recent discussion has made it clear that there is no community consensus
> on this particular rule.  Remove it now, lest it inspire yet another set
> of unwanted "cleanup" patches.
> 
> This partially reverts 865a1caa4b6b (CodingStyle: Clarify and complete
> chapter 7).
> (...)
> @@ -481,7 +478,7 @@ The rationale for using gotos is:
>  			goto out_buffer;
>  		}
>  		...
> -	 out_free_buffer:
> +	out_free_buffer:
>  		kfree(buffer);
>  		return result;
>  	}
> @@ -490,7 +487,7 @@ A common type of bug to be aware of is ``one err
> bugs`` which look like this: 
>  .. code-block:: c
>  
> -	 err:
> +	err:
>  		kfree(foo->bar);
>  		kfree(foo);
>  		return ret;

There are 2 more occurrences after this point, which you probably want
to change too.

-- 
Jean Delvare
SUSE L3 Support