linux-kernel - RE: [patch v1] drivers/platform/x86: introduce support for Mellanox hotplug driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM5PR0501MB20971F191335B0BB88243DF3A2C90@AM5PR0501MB2097.eurprd05.prod.outlook.com>
Date:   Thu, 22 Sep 2016 13:01:46 +0000
From:   Vadim Pasternak <vadimp@...lanox.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "dvhart@...radead.org" <dvhart@...radead.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "kvalo@...eaurora.org" <kvalo@...eaurora.org>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "jiri@...nulli.us" <jiri@...nulli.us>
Subject: RE: [patch v1] drivers/platform/x86: introduce support for Mellanox
 hotplug driver



> -----Original Message-----
> From: Greg KH [mailto:gregkh@...uxfoundation.org]
> Sent: Thursday, September 22, 2016 3:31 PM
> To: Vadim Pasternak <vadimp@...lanox.com>
> Cc: dvhart@...radead.org; davem@...emloft.net; geert@...ux-m68k.org;
> akpm@...ux-foundation.org; kvalo@...eaurora.org; mchehab@...nel.org;
> linux@...ck-us.net; linux-kernel@...r.kernel.org; platform-driver-
> x86@...r.kernel.org; jiri@...nulli.us
> Subject: Re: [patch v1] drivers/platform/x86: introduce support for Mellanox
> hotplug driver
> 
> On Thu, Sep 22, 2016 at 01:14:27PM +0000, vadimp@...lanox.com wrote:
> > From: Vadim Pasternak <vadimp@...lanox.com>
> >
> > Enable system support for the Mellanox Technologies hotplug platform
> > driver, which provides support for the next Mellanox basic systems:
> > "msx6710", "msx6720", "msb7700", "msn2700", "msx1410", "msn2410",
> > "msb7800", "msn2740", "msn2100" and also various number of derivative
> > systems from the above basic types.
> > This driver handles hot-plug events for the power suppliers, power
> > cables and fans for the above systems.
> >
> > The Kconfig currently controlling compilation of this code is:
> > driver/platform/x86:config MLX_CPLD_PLATFORM
> >                        tristate "Mellanox platform hotplug driver support"
> >
> > Signed-off-by: Vadim Pasternak <vadimp@...lanox.com>
> > ---
> >  MAINTAINERS                                   |   7 +
> >  drivers/platform/x86/Kconfig                  |  10 +
> >  drivers/platform/x86/Makefile                 |   1 +
> >  drivers/platform/x86/mlxcpld-hotplug.c        | 543
> ++++++++++++++++++++++++++
> >  include/linux/platform_data/mlxcpld-hotplug.h |  90 +++++
> 
> Why do you need a platform_data .h file for a stand-alone driver?
> 

I have another module mlx-platform, which is reviewed now (I also got a number feedbacks from you on this matter).
I want to activate mlxcpld-hotplug from this module. 
Like

/* Platform hotplug default data */
static struct mlxcpld_hotplug_platform_data mlxplat_mlxcpld_hotplug_default_data = {
 
/* Platform hotplug MSN21xx system family data*/
static struct mlxcpld_hotplug_platform_data mlxplat_mlxcpld_hotplug_msn21xx_data = {
...
	priv->pdev_hotplug = platform_device_register_resndata(
				&mlxplat_dev->dev, "mlxcpld-hotplug", -1,
				mlxplat_mlxcpld_hotplug_resources,
				ARRAY_SIZE(mlxplat_mlxcpld_hotplug_resources),
				mlxplat_hotplug, sizeof(*mlxplat_hotplug));

But I can't add this code to mlx-platfrom, until this one is not accepted.

Thanks,

Vadim.

> thanks,
> 
> greg k-h