linux-kernel - Re: [PATCH] drm/tilcdc: add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0b194cee-185d-4b10-f17f-a1a69f884453@ti.com>
Date:   Thu, 22 Sep 2016 18:56:25 +0300
From:   Jyri Sarha <jsarha@...com>
To:     Baoyou Xie <baoyou.xie@...aro.org>, <tomi.valkeinen@...com>,
        <airlied@...ux.ie>
CC:     <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <arnd@...db.de>, <xie.baoyou@....com.cn>
Subject: Re: [PATCH] drm/tilcdc: add missing header dependencies

Thanks,
But I have got this already:

https://lists.freedesktop.org/archives/dri-devel/2016-September/117900.html

I will send a pull request soon.

Best regards,
Jyri

On 09/21/16 08:12, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:397:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:402:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:453:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes]
> 
> In fact, these functions are declared in
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.h,
> drivers/gpu/drm/tilcdc/tilcdc_panel.h,
> so this patch adds missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_panel.c  | 1 +
>  drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 4ac1d25..186cf23 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -25,6 +25,7 @@
>  #include <drm/drm_atomic_helper.h>
>  
>  #include "tilcdc_drv.h"
> +#include "tilcdc_panel.h"
>  
>  struct panel_module {
>  	struct tilcdc_module base;
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index 741c7b5..8692671 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -23,6 +23,7 @@
>  #include <drm/drm_atomic_helper.h>
>  
>  #include "tilcdc_drv.h"
> +#include "tilcdc_tfp410.h"
>  
>  struct tfp410_module {
>  	struct tilcdc_module base;
>