linux-kernel - Re: [PATCH] staging:android:io: Fix multiple styling issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Sep 2016 20:22:03 +0200
From:   Markus Böhme <markus.boehme@...lbox.org>
To:     Yannis Damigos <giannis.damigos@...il.com>,
        gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, arve@...roid.com,
        riandrews@...roid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:android:io: Fix multiple styling issues

Hello Yannis!

There is a typo in your one-line description/subject ("ion").

On 09/22/2016 07:55 PM, Yannis Damigos wrote:
> This patch fixes 1 error, 1 warning and 14 checks found by
> checkpatch.

Please be more specific in your commit message and mention what exactly
you are doing to the code and why.

> 
> Signed-off-by: Yannis Damigos <giannis.damigos@...il.com>
> ---
>  drivers/staging/android/ion/ion_of.c | 49 ++++++++++++++++++------------------
>  1 file changed, 24 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
> index de0899a..c930416 100644
> --- a/drivers/staging/android/ion/ion_of.c
> +++ b/drivers/staging/android/ion/ion_of.c
> @@ -26,17 +26,17 @@
>  #include "ion_of.h"
>  
>  int ion_parse_dt_heap_common(struct device_node *heap_node,
> -			struct ion_platform_heap *heap,
> -			struct ion_of_heap *compatible)
> +			     struct ion_platform_heap *heap,
> +			     struct ion_of_heap *compatible)

You are changing whitespace here, ...

>  {
>  	int i;
>  
> -	for (i = 0; compatible[i].name != NULL; i++) {
> +	for (i = 0; compatible[i].name; i++) {

...  and are making a different kind of change here.

> (Rest of patch with yet other types of changes snipped.)

It would be nice to have each kind of change in a separate patch with a
more precise commit message.

Thanks,
Markus