linux-kernel - Re: [PATCH v2] dmaengine: s3c24xx: Add dma_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 22 Sep 2016 20:48:51 +0200
From:   Sam Van Den Berge <sam.van.den.berge@...enet.be>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     vinod.koul@...el.com, dmaengine@...r.kernel.org, kgene@...nel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        sam.van.den.berge@...enet.be
Subject: Re: [PATCH v2] dmaengine: s3c24xx: Add dma_slave_map for s3c2440
 devices

On Fri, Sep 16, 2016 at 01:16:31PM +0200, Krzysztof Kozlowski wrote:
> On 09/15/2016 09:41 PM, Sam Van Den Berge wrote:
> > This patch updates the s3c24xx dma driver to be able to pass a
> > dma_slave_map array via the platform data. This is needed to
> > be able to use the new, simpler dmaengine API [1].
> > I used the virtual DMA channels as a parameter for the dma_filter
> > function. By doing that, I could reuse the existing filter function in
> > drivers/dma/s3c24xx-dma.c.
> > 
> > I have tested this on my mini2440 board with the audio driver.
> > (I first applied the audio fixes from Sylwester Nawrocki [2])
> > According to my observations, dma_request_slave_channel in the
> > function dmaengine_pcm_new in the file
> > sound/soc/soc-generic-dmaengine-pcm.c now returns a valid DMA channel
> > whereas before no DMA channel was returned at that point.
> > 
> > Entries for DMACH_XD0, DMACH_XD1 and DMACH_TIMER are missing because I
> > don't realy know which driver to use for these.
> > 
> > [1]
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/393635.html
> > [2] http://www.spinics.net/lists/arm-kernel/msg521918.html
> > 
> > Signed-off-by: Sam Van Den Berge <sam.van.den.berge@...enet.be>
> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
> > Acked-by: Arnd Bergmann <arnd@...db.de>
> > 
> > ---
> > 
> > Changes since v1:
> > - rename arm into dmaengine in title
> > - one channel for s3c2440-sdi named "rx-tx"
> > 
> >  arch/arm/mach-s3c24xx/common.c            | 35 +++++++++++++++++++++++++++++++
> >  drivers/dma/s3c24xx-dma.c                 |  3 +++
> >  include/linux/platform_data/dma-s3c24xx.h |  6 ++++++
> >  3 files changed, 44 insertions(+)
> 
> Vinod, do you want to take it through your tree? Not much difference for
> me, so in such case:
> Acked-by: Krzysztof Kozlowski <krzk@...nel.org>

I was kinda waiting for an answer on this question because I didn't know
if I should add the acked-by or not but I'm going to assume that it's ok
so I'll include it in the third version of this patch.

> 
> Best regards,
> Krzysztof
> 
>