linux-kernel - RE: [PATCH v2] raid6/test/test.c: bug fix: Specify aligned(alignment) attributes to the char arrays

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Sep 2016 00:18:00 +0000
From:   "Kammela, Gayatri" <gayatri.kammela@...el.com>
To:     "linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "shli@...nel.org" <shli@...nel.org>,
        "Anvin, H Peter" <h.peter.anvin@...el.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        "Yu, Yu-cheng" <yu-cheng.yu@...el.com>
Subject: RE: [PATCH v2] raid6/test/test.c: bug fix: Specify
 aligned(alignment) attributes to the char arrays

Hi all,
Sorry for the noise! I didn't mean to send the version2.

-----Original Message-----
From: Kammela, Gayatri 
Sent: Thursday, September 22, 2016 5:08 PM
To: linux-raid@...r.kernel.org; linux-kernel@...r.kernel.org
Cc: shli@...nel.org; Anvin, H Peter <h.peter.anvin@...el.com>; Shankar, Ravi V <ravi.v.shankar@...el.com>; Yu, Fenghua <fenghua.yu@...el.com>; Kammela, Gayatri <gayatri.kammela@...el.com>; H . Peter Anvin <hpa@...or.com>; Yu, Yu-cheng <yu-cheng.yu@...el.com>
Subject: [PATCH v2] raid6/test/test.c: bug fix: Specify aligned(alignment) attributes to the char arrays

Specifying the aligned attributes to the char recovi[PAGE_SIZE] and char recovi[PAGE_SIZE] arrays, so that all malloc memory is page boundary aligned.

Without these alignment attributes, the test causes a segfault in userspace when the NDISKS are changed to 4 from 16.

Cc: H. Peter Anvin <hpa@...or.com>
Cc: Yu-cheng Yu <yu-cheng.yu@...el.com>
Signed-off-by: Gayatri Kammela <gayatri.kammela@...el.com>
---
 lib/raid6/test/test.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lib/raid6/test/test.c b/lib/raid6/test/test.c index 3bebbabdb510..32a00f11ac50 100644
--- a/lib/raid6/test/test.c
+++ b/lib/raid6/test/test.c
@@ -21,12 +21,13 @@
 
 #define NDISKS		16	/* Including P and Q */
 
-const char raid6_empty_zero_page[PAGE_SIZE] __attribute__((aligned(256)));
+const char raid6_empty_zero_page[PAGE_SIZE] 
+__attribute__((aligned(PAGE_SIZE)));
 struct raid6_calls raid6_call;
 
 char *dataptrs[NDISKS];
 char data[NDISKS][PAGE_SIZE];
-char recovi[PAGE_SIZE], recovj[PAGE_SIZE];
+char recovi[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE)));
+char recovj[PAGE_SIZE] __attribute__((aligned(PAGE_SIZE)));
 
 static void makedata(int start, int stop)  {
--
2.7.4