linux-kernel - Re: [PATCH] ASoC: simple-card: add support for aux devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Sep 2016 00:16:28 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Nikita Yushchenko <nikita.yoush@...entembedded.com>
CC:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Otto Kekäläinen <otto@...avo.fi>,
        Mengdong Lin <mengdong.lin@...ux.intel.com>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Andrew Lunn <andrew@...n.ch>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        <alsa-devel@...a-project.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH] ASoC: simple-card: add support for aux devices


Hi Nikita

> Example usage:
> 
> 	codec: tlv320dac3100@18 {
> 		compatible = "ti,tlv320dac3100";
> 		...
> 	}
> 
> 	amp: tpa6130a2@60 {
> 		compatible = "ti,tpa6130a2";
> 		...
> 	}
> 
> 	sound {
> 		compatible = "simple-audio-card";
> 		...
> 		simple-audio-card,widgets =
> 			"Headphone", "Headphone Jack";
> 		simple-audio-card,routing =
> 			"Headphone Jack", "HPLEFT",
> 			"Headphone Jack", "HPRIGHT",
> 			"LEFTIN", "HPL",
> 			"RIGHTIN", "HPR";
> 		simple-audio-card,aux-devs = <&amp>;
> 		simple-audio-card,cpu {
> 			sound-dai = <&ssi2>;
> 		};
> 		simple-audio-card,codec {
> 			sound-dai = <&codec1>;
> 			clocks = ...
> 		};

This case, I think you want ...

	simple-audio-card,codec {
-		sound-dai = <&codec1>;
+		sound-dai = <&codec>;


> diff --git a/Documentation/devicetree/bindings/sound/simple-card.txt b/Documentation/devicetree/bindings/sound/simple-card.txt
> index 59d8628..5579f40 100644
> --- a/Documentation/devicetree/bindings/sound/simple-card.txt
> +++ b/Documentation/devicetree/bindings/sound/simple-card.txt
> @@ -22,6 +22,8 @@ Optional properties:
>  					  headphones are attached.
>  - simple-audio-card,mic-det-gpio	: Reference to GPIO that signals when
>  					  a microphone is attached.
> +- simple-audio-card,aux-devs		: List of phandles pointing to auxiliary devices, such
> +					  as amplifiers, to be added to the sound card.
>  
>  Optional subnodes:

I think it is very helpful if this document has above sample

Best regards
---
Kuninori Morimoto