linux-kernel - Re: GPU-DRM-QXL: Move three assignments in qxl_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Sep 2016 17:53:46 +1000
From:   Dave Airlie <airlied@...il.com>
To:     Sean Paul <seanpaul@...omium.org>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        Kernel Janitors <kernel-janitors@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Julia Lawall <julia.lawall@...6.fr>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Tejun Heo <tj@...nel.org>, Thierry Reding <treding@...dia.com>,
        SF Markus Elfring <elfring@...rs.sourceforge.net>
Subject: Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

On 23 September 2016 at 17:25, Sean Paul <seanpaul@...omium.org> wrote:
> On Thu, Sep 22, 2016 at 1:24 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
>> On Thu, Sep 22, 2016 at 03:11:25PM +0200, SF Markus Elfring wrote:
>>> > If you restricted yourself to fixing bugs only then you would maybe fix more
>>> > bugs than you introduce but as it you are making the kernel worse.
>>>
>>> Would you like to discuss the statistics for my failure (or success) rate
>>> a bit more so that involved issues can be clarified in a constructive way?
>>
>> It should be that you target 20 bug fixes for each new regression that
>> you add.
>>
>> Since you are just sending clean ups, every bug you introduce sets us
>> further and further back.  There is no hope for improving the kernel
>> because you are not even trying to fix 20 bugs, only introducing them.
>>
>> Once you fix 20 bugs, then you will be even and you can start sending
>> cleanups again.  This is fair.
>>
>
> At the risk of piling on, but hopefully to benefit Markus going forward:
>
> I will refrain from merging any more style/checkpatch/"code cleanup"
> patches from Markus until we start getting real, tested, bug fixes.

I'd prefer if everyone on dri-devel just ignored Markus at this stage,

If you are going to pick up his patches, please spend time making sure they
are correct and tested, as he doesn't seem to.

Markus, please contact the list in advance in future before posting a bunch
of patches that don't fix any problems.

Dave.