linux-kernel - Re: [PATCHv2 5/5] staging:android:ion: Fix void function return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160923084439.GA32459@kroah.com>
Date:   Fri, 23 Sep 2016 10:44:39 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     giannis.damigos@...il.com
Cc:     markus.boehme@...lbox.org, arve@...roid.com, riandrews@...roid.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 5/5] staging:android:ion: Fix void function return

On Fri, Sep 23, 2016 at 11:05:17AM +0300, giannis.damigos@...il.com wrote:
> From: Yannis Damigos <giannis.damigos@...il.com>
> 
> This patch removes the return statement of void function
> 
> WARNING: void function return statements are not generally useful
> +	return;
> +}
> 
> Signed-off-by: Yannis Damigos <giannis.damigos@...il.com>
> ---
>  drivers/staging/android/ion/ion_of.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
> index 49f052c..c930416 100644
> --- a/drivers/staging/android/ion/ion_of.c
> +++ b/drivers/staging/android/ion/ion_of.c
> @@ -161,7 +161,6 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev)
>  static void rmem_ion_device_release(struct reserved_mem *rmem,
>  				    struct device *dev)
>  {
> -	return;
>  }

Why have an empty release function at all?  If it can be empty, you
should be able to drop the function entirely, right?

thanks,

greg k-h