linux-kernel - Re: [PATCH] ASoC: tlv320aic31xx: add explicit support for tlv320dac31xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1474621394.10437.19.camel@hadess.net>
Date:   Fri, 23 Sep 2016 11:03:14 +0200
From:   Bastien Nocera <hadess@...ess.net>
To:     Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Jyri Sarha <jsarha@...com>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Cc:     Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH] ASoC: tlv320aic31xx: add explicit support for
 tlv320dac31xx

On Thu, 2016-09-22 at 23:06 +0300, Nikita Yushchenko wrote:
> tlv320dac31xx is a subset of tlv320aic31xx:
> - it does not have MIC inputs and ADC, thus capture is not supported,
> - it has analog inputs AIN1/AIN2 that can be mixed into output.
> 
> Although tlv320dac31xx does work with tlv320aic31xx driver, this
> setup
> does register non-existent widgets and non-existent capture stream.
> Thus userspace lists non-existent objects in user interfaces, an can
> access these, causing operations with device registers that are
> declared as "reserved" in tlv320dac31xx datasheet.
> 
> This patch fixes this situation by separating controls/widgets/routes
> into common, aic31xx-specific, and dac31xx-specific parts. Only parts
> that match actual hardware (as declared in "compatible" device tree
> property) are registered.
> 
> Signed-off-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>

I don't have access to the hardware. My original patch allowed playback
to work (ish) on a specific device that I don't own. Probably best to
ignore my patch, or even revert it before applying this one.

Cheers