linux-kernel - Re: [PATCH] drm/tilcdc: fix wrong error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOw6vbJaqR5=pXBum1bmEfdJYepMxU+nKOAV87H2kKruPmrvmQ@mail.gmail.com>
Date:   Fri, 23 Sep 2016 05:01:56 -0700
From:   Sean Paul <seanpaul@...gle.com>
To:     Jyri Sarha <jsarha@...com>
Cc:     Daniel Schultz <d.schultz@...tec.de>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Dave Airlie <airlied@...ux.ie>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/tilcdc: fix wrong error handling

On Fri, Sep 23, 2016 at 5:01 AM, Jyri Sarha <jsarha@...com> wrote:
> On 09/23/16 14:47, Sean Paul wrote:
>> On Fri, Sep 23, 2016 at 3:52 AM, Daniel Schultz <d.schultz@...tec.de> wrote:
>>> When 'component_bind_all' fails it should not try to unbind components
>>> in the error handling. This will produce a null pointer kernel panic when
>>> no component exist.
>>>
>>> This patch changes the order of the error handling. Now, it will only
>>> unbind components if the are bound. Otherwise, the module will jump to
>>> an error label below.
>>>
>>> Signed-off-by: Daniel Schultz <d.schultz@...tec.de>
>>
>> Reviewed-by: Sean Paul <seanpaul@...omium.org>
>>
>
> Thanks, for both. Should I pick this one :)?
>

Yes, it's all yours! :)

Sean


> BR,
> Jyri
>
>>> ---
>>>  drivers/gpu/drm/tilcdc/tilcdc_drv.c | 6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>>> index d278093..d491610 100644
>>> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>>> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
>>> @@ -315,13 +315,13 @@ fail_irq_uninstall:
>>>  fail_vblank_cleanup:
>>>         drm_vblank_cleanup(dev);
>>>
>>> -fail_mode_config_cleanup:
>>> -       drm_mode_config_cleanup(dev);
>>> -
>>>  fail_component_cleanup:
>>>         if (priv->is_componentized)
>>>                 component_unbind_all(dev->dev, dev);
>>>
>>> +fail_mode_config_cleanup:
>>> +       drm_mode_config_cleanup(dev);
>>> +
>>>  fail_external_cleanup:
>>>         tilcdc_remove_external_encoders(dev);
>>>
>>> --
>>> 1.9.1
>>>
>