linux-kernel - Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Sep 2016 14:06:52 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yannis Damigos <giannis.damigos@...il.com>
Cc:     markus.boehme@...lbox.org, devel@...verdev.osuosl.org,
        arve@...roid.com, riandrews@...roid.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv3 5/5] staging:android:ion: Remove empty release function

On Fri, Sep 23, 2016 at 12:50:15PM +0300, Yannis Damigos wrote:
> This patch removes the empty function rmem_ion_device_release
> 
> Signed-off-by: Yannis Damigos <giannis.damigos@...il.com>
> ---
>  drivers/staging/android/ion/ion_of.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c
> index 49f052c..91c0642 100644
> --- a/drivers/staging/android/ion/ion_of.c
> +++ b/drivers/staging/android/ion/ion_of.c
> @@ -158,15 +158,8 @@ static int rmem_ion_device_init(struct reserved_mem *rmem, struct device *dev)
>  	return 0;
>  }
>  
> -static void rmem_ion_device_release(struct reserved_mem *rmem,
> -				    struct device *dev)
> -{
> -	return;
> -}
> -
>  static const struct reserved_mem_ops rmem_dma_ops = {
>  	.device_init	= rmem_ion_device_init,
> -	.device_release	= rmem_ion_device_release,
>  };
>  
>  static int __init rmem_ion_setup(struct reserved_mem *rmem)
> -- 
> 2.10.0

Have you tested that this works?

thanks,

greg k-h