linux-kernel - Re: GPU-DRM-QXL: Move three assignments in qxl_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACvgo53Fc+xFeGnmmdDJJjrgmB3vA77gct4EngONuZ+Xym4_gQ@mail.gmail.com>
Date:   Fri, 23 Sep 2016 14:30:06 +0100
From:   Emil Velikov <emil.l.velikov@...il.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Dave Airlie <airlied@...il.com>,
        Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        Julia Lawall <julia.lawall@...6.fr>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Tejun Heo <tj@...nel.org>, Thierry Reding <treding@...dia.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: GPU-DRM-QXL: Move three assignments in qxl_device_init()

On 23 September 2016 at 09:50, SF Markus Elfring
<elfring@...rs.sourceforge.net> wrote:
>> Markus, please contact the list in advance in future before posting a bunch
>> of patches that don't fix any problems.
>
> I am trying to improve various open issues also in Linux source files.
>
That the fact that you see issues (in these particular cases) while
others do not indicates that the commit summary could be explained
better.

A good commit summary should provide enough information to do that and
make people _want_ the patch. From my limited experience through your
patches (just skimmed a few) you seems to be describing what the patch
does as opposed to why it does it and why should one find it
interesting/wanted.

You might want to read through the following [1] [2] and many others
that exist out there.

-Emil

[1] http://chris.beams.io/posts/git-commit/
[2] http://who-t.blogspot.fi/2009/12/on-commit-messages.html