linux-kernel - Re: [PATCH] kcov: do not instrument lib/stackdepot.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACT4Y+Y82XHFuxN72PW65QOvMW7Z6y2ojWGg05pO5N7SfLxJXg@mail.gmail.com>
Date:   Fri, 23 Sep 2016 16:38:31 +0200
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Alexander Potapenko <glider@...gle.com>
Cc:     Kostya Serebryany <kcc@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        syzkaller <syzkaller@...glegroups.com>
Subject: Re: [PATCH] kcov: do not instrument lib/stackdepot.c

On Fri, Sep 23, 2016 at 4:29 PM, Alexander Potapenko <glider@...gle.com> wrote:
> There's no point in collecting coverage from lib/stackdepot.c, as it is
> not a function of syscall inputs. Disabling kcov instrumentation for
> that file will reduce the coverage noise level.
>
> Signed-off-by: Alexander Potapenko <glider@...gle.com>

Acked-by: Dmitry Vyukov <dvyukov@...gle.com>


> ---
>  lib/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 5dc77a8..cbac596 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -180,6 +180,7 @@ obj-$(CONFIG_IRQ_POLL) += irq_poll.o
>
>  obj-$(CONFIG_STACKDEPOT) += stackdepot.o
>  KASAN_SANITIZE_stackdepot.o := n
> +KCOV_INSTRUMENT_stackdepot.o := n
>
>  libfdt_files = fdt.o fdt_ro.o fdt_wip.o fdt_rw.o fdt_sw.o fdt_strerror.o \
>                fdt_empty_tree.o
> --
> 2.8.0.rc3.226.g39d4020
>