linux-kernel - Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Sep 2016 17:06:42 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yannis Damigos <giannis.damigos@...il.com>
Cc:     devel@...verdev.osuosl.org, arve@...roid.com,
        riandrews@...roid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 3/5] staging:android:ion: Fix blank line issues

On Fri, Sep 23, 2016 at 04:26:28PM +0300, Yannis Damigos wrote:
> On Fri, Sep 23, 2016 at 3:17 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> > On Fri, Sep 23, 2016 at 11:05:15AM +0300, giannis.damigos@...il.com wrote:
> >> From: Yannis Damigos <giannis.damigos@...il.com>
> >>
> >> This patch fixes the following blank line issues:
> >>
> >> CHECK: Please don't use multiple blank lines
> >> +
> >> +
> >
> > What does that mean with the + + lines?
> >
> >>
> >> CHECK: Please use a blank line after function/struct/union/enum
> >> declarations
> >> +}
> >> +RESERVEDMEM_OF_DECLARE(ion, "ion-region", rmem_ion_setup);
> >
> > Linewrap :(
> >
> If the line is not wrapped, I get the following warning:
> Possible unwrapped commit description (prefer a maximum 75 chars per line)
> 
> Should I ignore it?

Don't you think it makes sense to do so?  :)