linux-kernel - Re: [PATCH 1/2] Staging: ks7010: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160923171020.GA28694@kroah.com>
Date:   Fri, 23 Sep 2016 19:10:20 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     wsa@...-dreams.de, bhumirks@...il.com, dan.carpenter@...cle.com,
        julia.lawall@...6.fr, weiyongjun1@...wei.com,
        karniksayli1995@...il.com, devel@...verdev.osuosl.org,
        xie.baoyou@....com.cn, linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH 1/2] Staging: ks7010: mark symbols static where possible

On Fri, Sep 23, 2016 at 09:22:29PM +0800, Baoyou Xie wrote:
> We get 3 warnings when building kernel with W=1:
> drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous prototype for 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes]
> drivers/staging/ks7010/ks7010_sdio.c:120:6: warning: no previous prototype for 'ks_wlan_hw_sleep_wakeup_request' [-Wmissing-prototypes]
> drivers/staging/ks7010/ks7010_sdio.c:172:5: warning: no previous prototype for '_ks_wlan_hw_power_save' [-Wmissing-prototypes]
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/staging/ks7010/ks7010_sdio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Does not apply cleanly, are you sure you are using the latest tree?

Can you fix it up and resend?

thanks,

greg k-h