linux-kernel - Re: [PATCH] vme: fake: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEccXeeYauywQjuarLDLcUtw35ckw2XL+Gq7SZvek47uej3eHg@mail.gmail.com>
Date:   Fri, 23 Sep 2016 21:31:13 +0100
From:   Martyn Welch <martyn@...chs.me.uk>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     Manohar Vanga <manohar.vanga@...il.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        devel <devel@...verdev.osuosl.org>,
        LKML <linux-kernel@...r.kernel.org>, xie.baoyou@....com.cn
Subject: Re: [PATCH] vme: fake: mark symbols static where possible

On 23 September 2016 at 14:38, Baoyou Xie <baoyou.xie@...aro.org> wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/vme/bridges/vme_fake.c:384:6: warning: no previous prototype for 'fake_lm_check' [-Wmissing-prototypes]
> drivers/vme/bridges/vme_fake.c:619:6: warning: no previous prototype for 'fake_vmewrite8' [-Wmissing-prototypes]
> drivers/vme/bridges/vme_fake.c:649:6: warning: no previous prototype for 'fake_vmewrite16' [-Wmissing-prototypes]
> drivers/vme/bridges/vme_fake.c:679:6: warning: no previous prototype for 'fake_vmewrite32' [-Wmissing-prototypes]
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> so this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Acked-by: Martyn Welch <martyn@...chs.me.uk>

> ---
>  drivers/vme/bridges/vme_fake.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/vme/bridges/vme_fake.c b/drivers/vme/bridges/vme_fake.c
> index ebf35d3..29ac74f 100644
> --- a/drivers/vme/bridges/vme_fake.c
> +++ b/drivers/vme/bridges/vme_fake.c
> @@ -381,8 +381,8 @@ static int fake_master_get(struct vme_master_resource *image, int *enabled,
>  }
>
>
> -void fake_lm_check(struct fake_driver *bridge, unsigned long long addr,
> -               u32 aspace, u32 cycle)
> +static void fake_lm_check(struct fake_driver *bridge, unsigned long long addr,
> +                         u32 aspace, u32 cycle)
>  {
>         struct vme_bridge *fake_bridge;
>         unsigned long long lm_base;
> @@ -616,8 +616,8 @@ static ssize_t fake_master_read(struct vme_master_resource *image, void *buf,
>         return retval;
>  }
>
> -void fake_vmewrite8(struct fake_driver *bridge, u8 *buf,
> -                unsigned long long addr, u32 aspace, u32 cycle)
> +static void fake_vmewrite8(struct fake_driver *bridge, u8 *buf,
> +                          unsigned long long addr, u32 aspace, u32 cycle)
>  {
>         int i;
>         unsigned long long start, end, offset;
> @@ -646,8 +646,8 @@ void fake_vmewrite8(struct fake_driver *bridge, u8 *buf,
>
>  }
>
> -void fake_vmewrite16(struct fake_driver *bridge, u16 *buf,
> -               unsigned long long addr, u32 aspace, u32 cycle)
> +static void fake_vmewrite16(struct fake_driver *bridge, u16 *buf,
> +                           unsigned long long addr, u32 aspace, u32 cycle)
>  {
>         int i;
>         unsigned long long start, end, offset;
> @@ -676,8 +676,8 @@ void fake_vmewrite16(struct fake_driver *bridge, u16 *buf,
>
>  }
>
> -void fake_vmewrite32(struct fake_driver *bridge, u32 *buf,
> -               unsigned long long addr, u32 aspace, u32 cycle)
> +static void fake_vmewrite32(struct fake_driver *bridge, u32 *buf,
> +                           unsigned long long addr, u32 aspace, u32 cycle)
>  {
>         int i;
>         unsigned long long start, end, offset;
> --
> 2.7.4
>