linux-kernel - Re: [PATCH v4] staging: ion: Fix a coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2b2a3c6-d6cd-f1ad-2d03-22e4a5279228@redhat.com>
Date:   Fri, 23 Sep 2016 13:36:53 -0700
From:   Laura Abbott <labbott@...hat.com>
To:     Antti Keränen <detegr@...il.com>
Cc:     sumit.semwal@...aro.org, gregkh@...uxfoundation.org,
        arve@...roid.com, riandrews@...roid.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] staging: ion: Fix a coding style issue

On 09/23/2016 11:03 AM, Antti Keränen wrote:
> This patch fixes the alignment of an allocation flag block comment
> and moves the comments before each #define.
>

Acked-by: Laura Abbott <labbott@...hat.com>

> Signed-off-by: Antti Keränen <detegr@...il.com>
> ---
> In addition to fixing the alignment issue, this version of the patch moves
> the comments from after the define lines to before the define lines.
>
>  drivers/staging/android/uapi/ion.h | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 647f130..14cd873 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -52,18 +52,18 @@ enum ion_heap_type {
>   * allocation flags - the lower 16 bits are used by core ion, the upper 16
>   * bits are reserved for use by the heaps themselves.
>   */
> -#define ION_FLAG_CACHED 1		/*
> -					 * mappings of this buffer should be
> -					 * cached, ion will do cache
> -					 * maintenance when the buffer is
> -					 * mapped for dma
> -					*/
> -#define ION_FLAG_CACHED_NEEDS_SYNC 2	/*
> -					 * mappings of this buffer will created
> -					 * at mmap time, if this is set
> -					 * caches must be managed
> -					 * manually
> -					 */
> +
> +/*
> + * mappings of this buffer should be cached, ion will do cache maintenance
> + * when the buffer is mapped for dma
> + */
> +#define ION_FLAG_CACHED 1
> +
> +/*
> + * mappings of this buffer will created at mmap time, if this is set
> + * caches must be managed manually
> + */
> +#define ION_FLAG_CACHED_NEEDS_SYNC 2
>
>  /**
>   * DOC: Ion Userspace API
>