linux-kernel - Re: [PATCH 1/1] mm/percpu.c: correct max_distance calculation for pcpu_embed_first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160923213030.GG31387@htj.duckdns.org>
Date:   Fri, 23 Sep 2016 17:30:30 -0400
From:   Tejun Heo <tj@...nel.org>
To:     zijun_hu <zijun_hu@...o.com>
Cc:     zijun_hu@....com, Andrew Morton <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-mm@...ck.org, cl@...ux.com
Subject: Re: [PATCH 1/1] mm/percpu.c: correct max_distance calculation for
 pcpu_embed_first_chunk()

Hello,

On Sat, Sep 24, 2016 at 05:16:56AM +0800, zijun_hu wrote:
> On 2016/9/24 3:23, Tejun Heo wrote:
> > On Sat, Sep 24, 2016 at 02:20:24AM +0800, zijun_hu wrote:
> >> From: zijun_hu <zijun_hu@....com>
> >>
> >> correct max_distance from (base of the highest group + ai->unit_size)
> >> to (base of the highest group + the group size)
> >>
> >> Signed-off-by: zijun_hu <zijun_hu@....com>
> > 
> > Nacked-by: Tejun Heo <tj@...nel.org>
> > 
> > Thanks.
> >
> frankly, the current max_distance is error, doesn't represents the ranges spanned by
> areas owned by the groups

I think you're right but can you please update the patch description
so that it explains what the bug and the implications are and how the
patch fixes the bug.  Also, please make sure that all changes made by
the patch are explained in the description - e.g. why the type of
@max_distance is changed from size_t to ulong.

Thanks.

-- 
tejun