linux-kernel - Re: [PATCH 1/2] Staging: ks7010: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2571045.85xaKF6mvo@wuerfel>
Date:   Sat, 24 Sep 2016 11:14:03 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>, wsa@...-dreams.de,
        Bhumika Goyal <bhumirks@...il.com>, dan.carpenter@...cle.com,
        Julia Lawall <julia.lawall@...6.fr>, weiyongjun1@...wei.com,
        sayli karnik <karniksayli1995@...il.com>,
        devel@...verdev.osuosl.org, xie.baoyou@....com.cn,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] Staging: ks7010: mark symbols static where possible

On Saturday, September 24, 2016 9:34:41 AM CEST Baoyou Xie wrote:
> On 24 September 2016 at 01:10, Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> > On Fri, Sep 23, 2016 at 09:22:29PM +0800, Baoyou Xie wrote:
> > > We get 3 warnings when building kernel with W=1:
> > > drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no previous
> > prototype for 'ks_wlan_hw_sleep_doze_request' [-Wmissing-prototypes]
> > > drivers/staging/ks7010/ks7010_sdio.c:120:6: warning: no previous
> > prototype for 'ks_wlan_hw_sleep_wakeup_request' [-Wmissing-prototypes]
> > > drivers/staging/ks7010/ks7010_sdio.c:172:5: warning: no previous
> > prototype for '_ks_wlan_hw_power_save' [-Wmissing-prototypes]
> > >
> > > In fact, these functions are only used in the file in which they are
> > > declared and don't need a declaration, but can be made static.
> > > so this patch marks these functions with 'static'.
> > >
> > > Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> > > ---
> > >  drivers/staging/ks7010/ks7010_sdio.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > Does not apply cleanly, are you sure you are using the latest tree?
> >
> I worked on linux next-20160922 tag, could you tell me how to find the
> valid tree?

The file saw a couple of small changes in next-20160923, so I think
this was just unfortunate timing but you used the right tree.

staging can be moving very rapidly at times, so if you want to
be sure to get the right tree of the minute, you can
rebase on top of

git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing

I usually just base on top of the linux-next of the day, which tends
to work well enough.

	Arnd