linux-kernel - Re: [PATCH v3] gpio: Added zynq specific check for special pins on bank zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <355c3a93-0f7d-adc1-224e-ac48afacbcb9@gmail.com>
Date:   Sat, 24 Sep 2016 18:18:13 +0300
From:   Vesa Jääskeläinen <dachaac@...il.com>
To:     Nava kishore Manne <nava.manne@...inx.com>,
        linus.walleij@...aro.org, gnurou@...il.com,
        michal.simek@...inx.com, soren.brinkmann@...inx.com,
        linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Cc:     Nava kishore Manne <navam@...inx.com>
Subject: Re: [PATCH v3] gpio: Added zynq specific check for special pins on
 bank zero

On 23/09/2016 14.26, Nava kishore Manne wrote:
> From: Nava kishore Manne <nava.manne@...inx.com>
>
> This patch adds zynq specific check for bank 0 pins 7 and 8
> are special and cannot be used as inputs
>
> Signed-off-by: Nava kishore Manne <navam@...inx.com>
> Reported-by: Jonas Karlsson <Jonas.d.karlsson@...il.com>
> Acked-by: Sören Brinkmann <soren.brinkmann@...inx.com>
> Acked-by: Michal Simek <michal.simek@...inx.com>
> ---
> Changes for v3:
> 		-Fixed some minor comments.
> Changes for v2:
>                  -Removed un-used quirks for zynqmp.
>
>   drivers/gpio/gpio-zynq.c | 15 +++++++++++++--
>   1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
> index e72794e..6b4d10d 100644
> --- a/drivers/gpio/gpio-zynq.c
> +++ b/drivers/gpio/gpio-zynq.c
> @@ -96,6 +96,9 @@
>   /* GPIO upper 16 bit mask */
>   #define ZYNQ_GPIO_UPPER_MASK 0xFFFF0000
>   
> +/* For GPIO quirks */
> +#define ZYNQ_GPIO_QUIRK_FOO	BIT(0)
Should this be a bit more descriptive than FOO?