linux-kernel - [PATCH] HSI: omap_ssi_core: move function declaration to header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 24 Sep 2016 13:11:56 +0800
From:   Baoyou Xie <baoyou.xie@...aro.org>
To:     sre@...nel.org
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de, baoyou.xie@...aro.org,
        xie.baoyou@....com.cn
Subject: [PATCH] HSI: omap_ssi_core: move function declaration to header file

We get 1 warning when building kernel with W=1:
drivers/hsi/controllers/omap_ssi_core.c:181:6: warning: no previous prototype for 'ssi_waketest' [-Wmissing-prototypes]

In fact, this function is declared in
drivers/hsi/clients/ssi_protocol.c, but should be declared
in a header file. So this patch moves the function declaration
to include/linux/hsi/hsi.h.

Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
---
 drivers/hsi/clients/ssi_protocol.c | 2 --
 include/linux/hsi/hsi.h            | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
index 6031cd1..fe86444 100644
--- a/drivers/hsi/clients/ssi_protocol.c
+++ b/drivers/hsi/clients/ssi_protocol.c
@@ -45,8 +45,6 @@
 #include <linux/hsi/hsi.h>
 #include <linux/hsi/ssi_protocol.h>
 
-void ssi_waketest(struct hsi_client *cl, unsigned int enable);
-
 #define SSIP_TXQUEUE_LEN	100
 #define SSIP_MAX_MTU		65535
 #define SSIP_DEFAULT_MTU	4000
diff --git a/include/linux/hsi/hsi.h b/include/linux/hsi/hsi.h
index 5740254..676a656 100644
--- a/include/linux/hsi/hsi.h
+++ b/include/linux/hsi/hsi.h
@@ -161,6 +161,7 @@ static inline void *hsi_client_drvdata(struct hsi_client *cl)
 int hsi_register_port_event(struct hsi_client *cl,
 			void (*handler)(struct hsi_client *, unsigned long));
 int hsi_unregister_port_event(struct hsi_client *cl);
+void ssi_waketest(struct hsi_client *cl, unsigned int enable);
 
 /**
  * struct hsi_client_driver - Driver associated to an HSI client
-- 
2.7.4