linux-kernel - Re: [PATCH 2/3] dmaengine: pxa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2223993.4ZykH5Lksh@wuerfel>
Date:   Sat, 24 Sep 2016 11:05:45 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     dan.j.williams@...el.com, vinod.koul@...el.com,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        xie.baoyou@....com.cn
Subject: Re: [PATCH 2/3] dmaengine: pxa_dma: add function declaration

On Saturday, September 24, 2016 12:58:39 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/dma/pxa_dma.c:1525:5: warning: no previous prototype for 'pxad_toggle_reserved_channel' [-Wmissing-prototypes]
> 
> In fact, this function is undeclared in any header files.
> 
> So this patch adds function declaration in include/linux/dma/pxa-dma.h.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> 

No, this is wrong: the function was originally introduced as the
interface between  drivers/dma/pxa_dma.c and arch/arm/plat-pxa/dma.c,
but the latter file has been removed recently, along with the
declaration.

Please remove the function as well now.

In the future, when you find an exported function without a
declaration, don't assume that it should be declared, but instead
look up the git history of that identifier to see if the users
were all removed, or if it was perhaps never used.

	Arnd