linux-kernel - Re: [PATCH] clk: versatile: add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2048131.z1JiX2E8WD@wuerfel>
Date:   Sat, 24 Sep 2016 11:09:17 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     mturquette@...libre.com, sboyd@...eaurora.org,
        linus.walleij@...aro.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, xie.baoyou@....com.cn
Subject: Re: [PATCH] clk: versatile: add missing header dependencies

On Saturday, September 24, 2016 12:31:40 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]
> 
> In fact, this function is declared in
> include/linux/platform_data/clk-realview.h,
> so this patch adds missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> 

I think I commented on this one already: the only caller of the
function is getting removed in v4.9, so we should remove the
definition of the function subsequently in the next release.

We could in theory try to remove this at the same time, but
the effort to synchronize the git trees is not worth the benefit.

	Arnd