linux-kernel - Re: [PATCH 2/2] drm/tilcdc: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 25 Sep 2016 14:22:53 +0300
From:   Jyri Sarha <jsarha@...com>
To:     Baoyou Xie <baoyou.xie@...aro.org>, <tomi.valkeinen@...com>,
        <airlied@...ux.ie>
CC:     <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
        <arnd@...db.de>, <xie.baoyou@....com.cn>, <han.fei@....com.cn>,
        <tang.qiang007@....com.cn>
Subject: Re: [PATCH 2/2] drm/tilcdc: mark symbols static where possible

On 09/25/16 10:16, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:142:29: warning: no previous prototype for 'tilcdc_get_overlay' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:198:13: warning: no previous prototype for 'tilcdc_convert_slave_node' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c:264:12: warning: no previous prototype for 'tilcdc_slave_compat_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning: no previous prototype for 'tilcdc_atomic_check' [-Wmissing-prototypes]
> 
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> So this patch marks these functions with 'static'.
> 

These warnings have also been fixed already and the fixes are queued for
v4.9. Please do not send this patch (or any other patch fixing the same
issue) to me anymore!

Best regards,
Jyri

> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_drv.c          | 2 +-
>  drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index f8892e9..562ee7f 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -75,7 +75,7 @@ static void tilcdc_fb_output_poll_changed(struct drm_device *dev)
>  	drm_fbdev_cma_hotplug_event(priv->fbdev);
>  }
>  
> -int tilcdc_atomic_check(struct drm_device *dev,
> +static int tilcdc_atomic_check(struct drm_device *dev,
>  			struct drm_atomic_state *state)
>  {
>  	int ret;
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> index f9c79da..dd8de260 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> @@ -139,7 +139,7 @@ static void __init tilcdc_node_disable(struct device_node *node)
>  	of_update_property(node, prop);
>  }
>  
> -struct device_node * __init tilcdc_get_overlay(struct kfree_table *kft)
> +static struct device_node * __init tilcdc_get_overlay(struct kfree_table *kft)
>  {
>  	const int size = __dtb_tilcdc_slave_compat_end -
>  		__dtb_tilcdc_slave_compat_begin;
> @@ -195,7 +195,7 @@ static const char * const tilcdc_slave_props[] __initconst = {
>  	NULL
>  };
>  
> -void __init tilcdc_convert_slave_node(void)
> +static void __init tilcdc_convert_slave_node(void)
>  {
>  	struct device_node *slave = NULL, *lcdc = NULL;
>  	struct device_node *i2c = NULL, *fragment = NULL;
> @@ -261,7 +261,7 @@ void __init tilcdc_convert_slave_node(void)
>  	of_node_put(fragment);
>  }
>  
> -int __init tilcdc_slave_compat_init(void)
> +static int __init tilcdc_slave_compat_init(void)
>  {
>  	tilcdc_convert_slave_node();
>  	return 0;
>