linux-kernel - Re: [PATCH -next] staging: most: fix error return code in audio_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160925172649.GA21177@kroah.com>
Date:   Sun, 25 Sep 2016 19:26:49 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     Christian Gromm <christian.gromm@...rochip.com>,
        Andrey Shvetsov <andrey.shvetsov@....de>,
        Shraddha Barke <shraddha.6596@...il.com>,
        devel@...verdev.osuosl.org, Wei Yongjun <weiyongjun1@...wei.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] staging: most: fix error return code in
 audio_probe_channel()

On Sun, Sep 25, 2016 at 03:41:11PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> Fix to return a negative error code from the audio_set_hw_params() error
> handling case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/staging/most/aim-sound/sound.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sound.c
> index 3dc625c..00f01c9 100644
> --- a/drivers/staging/most/aim-sound/sound.c
> +++ b/drivers/staging/most/aim-sound/sound.c
> @@ -607,7 +607,8 @@ static int audio_probe_channel(struct most_interface *iface, int channel_id,
>  	channel->id = channel_id;
>  	init_waitqueue_head(&channel->playback_waitq);
>  
> -	if (audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg))
> +	ret = audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg);
> +	if (ret)
>  		goto err_free_card;

Are you sure you want that error value?  I need an ack from the driver
maintainers before I can take this...

thanks,

greg k-h