linux-kernel - Re: [PATCH][V2] mlxsw: spectrum: remove redundant check if err is zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160925050855.GA4050@splinter>
Date:   Sun, 25 Sep 2016 08:08:55 +0300
From:   Ido Schimmel <idosch@...sch.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Hariprasad S <hariprasad@...lsio.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] mlxsw: spectrum: remove redundant check if err is
 zero

On Sat, Sep 24, 2016 at 06:03:38PM -0700, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There is an earlier check and return if err is non-zero, so
> the check to see if it is zero is redundant in every iteration
> of the loop and hence the check can be removed.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

The subject and commit message are wrong. I think you copy-pasted them
from an earlier patch.

> ---
>  drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> index 2a61617..1073673 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
> @@ -117,11 +117,11 @@ static int validate_filter(struct net_device *dev,
>  	return 0;
>  }
>  
> -static unsigned int get_filter_steerq(struct net_device *dev,
> -				      struct ch_filter_specification *fs)
> +static int get_filter_steerq(struct net_device *dev,
> +			     struct ch_filter_specification *fs)
>  {
>  	struct adapter *adapter = netdev2adap(dev);
> -	unsigned int iq;
> +	int iq;
>  
>  	/* If the user has requested steering matching Ingress Packets
>  	 * to a specific Queue Set, we need to make sure it's in range
> @@ -443,10 +443,10 @@ int __cxgb4_set_filter(struct net_device *dev, int filter_id,
>  		       struct filter_ctx *ctx)
>  {
>  	struct adapter *adapter = netdev2adap(dev);
> -	unsigned int max_fidx, fidx, iq;
> +	unsigned int max_fidx, fidx;
>  	struct filter_entry *f;
>  	u32 iconf;
> -	int ret;
> +	int iq, ret;
>  
>  	max_fidx = adapter->tids.nftids;
>  	if (filter_id != (max_fidx + adapter->tids.nsftids - 1) &&
> -- 
> 2.9.3
>