linux-kernel - Re: [PATCH] drm: bridge: analogix/dp: mark symbols static where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 25 Sep 2016 23:02:18 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     airlied@...ux.ie, ykk@...k-chips.com, inki.dae@...sung.com,
        seanpaul@...omium.org, gustavo.padovan@...labora.co.uk,
        daniel.vetter@...ll.ch, ville.syrjala@...ux.intel.com,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        arnd@...db.de, xie.baoyou@....com.cn, han.fei@....com.cn,
        tang.qiang007@....com.cn
Subject: Re: [PATCH] drm: bridge: analogix/dp: mark symbols static where
 possible

On Sun, Sep 25, 2016 at 03:32:44PM +0800, Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1053:5: warning: no previous prototype for 'analogix_dp_get_modes' [-Wmissing-prototypes]
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1097:1: warning: no previous prototype for 'analogix_dp_detect' [-Wmissing-prototypes]
> 
> In fact, both functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> So this patch marks both functions with 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

This and your drm/bochs patch applied to drm-misc, thanks.
-Daniel

> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index efac8ab..e6f7290 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1050,7 +1050,7 @@ out:
>  	return ret;
>  }
>  
> -int analogix_dp_get_modes(struct drm_connector *connector)
> +static int analogix_dp_get_modes(struct drm_connector *connector)
>  {
>  	struct analogix_dp_device *dp = to_dp(connector);
>  	struct edid *edid = (struct edid *)dp->edid;
> @@ -1093,7 +1093,7 @@ static const struct drm_connector_helper_funcs analogix_dp_connector_helper_func
>  	.best_encoder = analogix_dp_best_encoder,
>  };
>  
> -enum drm_connector_status
> +static enum drm_connector_status
>  analogix_dp_detect(struct drm_connector *connector, bool force)
>  {
>  	struct analogix_dp_device *dp = to_dp(connector);
> -- 
> 2.7.4
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch