linux-kernel - Re: [PATCH, TRIVIAL] Fixed block comment coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <35eaaaa1-7bcf-4d6e-6472-8ce9a4d9dcbf@lwfinger.net>
Date:   Sun, 25 Sep 2016 17:57:07 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Gonçalo Salazar <glbsalazar@...il.com>,
        florian.c.schilhabel@...glemail.com, gregkh@...uxfoundation.org,
        trivial@...nel.org, devel@...verdev.osuosl.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH, TRIVIAL] Fixed block comment coding style

On 09/25/2016 04:18 PM, Gonçalo Salazar wrote:
> Fixed a block comment indentation in the rtl8712 usb_intf.c file.
> Made this as a first commit.
>
> Please let me know of any feedback you have.
>
> Thanks,
> Gonçalo Salazar

Your subject heeds to specify which driver is involved. In addition, fixes for 
staging drivers also need that indicated as well. Thus your subject should be 
"staging: rtl8172: Fix block...". When you resubmit, have it read "[PATCH V2}".
>
> Signed-off-by: Gonçalo Salazar <glbsalazar@...il.com>
> ---
>  drivers/staging/rtl8712/usb_intf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
> index 3fc65b2..897d462 100644
> --- a/drivers/staging/rtl8712/usb_intf.c
> +++ b/drivers/staging/rtl8712/usb_intf.c
> @@ -369,7 +369,7 @@ static const struct device_type wlan_type = {
>   *
>   * notes: drv_init() is called when the bus driver has located a card for us
>   * to support. We accept the new device by returning 0.
> -*/
> + */
>  static int r871xu_drv_init(struct usb_interface *pusb_intf,
>  			   const struct usb_device_id *pdid)
>  {
>