linux-kernel - Re: [PATCH 1/2] mfd: ab8500-debugfs: add function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <201609260129.41684.arnd@arndb.de>
Date:   Mon, 26 Sep 2016 01:29:41 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        xie.baoyou@....com.cn, tang.qiang007@....com.cn, han.fei@....com.cn
Subject: Re: [PATCH 1/2] mfd: ab8500-debugfs: add function declaration

On Sunday 25 September 2016, Baoyou Xie wrote:
> On 24 September 2016 at 16:30, Arnd Bergmann <arnd@...db.de> wrote:
> >
> > This can't be right for two reasons:
> >
> > - the suspend_test_wake_cause_interrupt_is_mine function again
> >   is only used in the file it is defined in
> >
> 
> but, it is declared as weak, so other modules can implement it.

In theory that is correct, but doing that would be very unusual
and bad style. As nobody does this at the moment, and the driver is for
obsolete hardware, just remove it now, and if we ever need want to
override it, that should be done using a runtime callback handler
or something completely different.

	Arnd