linux-kernel - Re: [PATCH -next] staging: most: fix error return code in audio_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160926105606.4d4033be@muaddib>
Date:   Mon, 26 Sep 2016 10:56:06 +0200
From:   Christian Gromm <christian.gromm@...rochip.com>
To:     Wei Yongjun <weiyj.lk@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Andrey Shvetsov <andrey.shvetsov@....de>,
        Shraddha Barke <shraddha.6596@...il.com>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] staging: most: fix error return code in
 audio_probe_channel()

On Mon, 26 Sep 2016 09:47:19 +0200
Andrey Shvetsov <andrey.shvetsov@....de> wrote:

> On Sun, Sep 25, 2016 at 03:41:11PM +0000, Wei Yongjun wrote:
> > From: Wei Yongjun <weiyongjun1@...wei.com>
> > 
> > Fix to return a negative error code from the audio_set_hw_params() error
> > handling case instead of 0, as done elsewhere in this function.
> > 
> > Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> Signed-off-by: Andrey Shvetsov <andrey.shvetsov@....de>

Signed-off-by: Christian Gromm <christian.gromm@...rochip.com>

> 
> > ---
> >  drivers/staging/most/aim-sound/sound.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sound.c
> > index 3dc625c..00f01c9 100644
> > --- a/drivers/staging/most/aim-sound/sound.c
> > +++ b/drivers/staging/most/aim-sound/sound.c
> > @@ -607,7 +607,8 @@ static int audio_probe_channel(struct most_interface *iface, int channel_id,
> >  	channel->id = channel_id;
> >  	init_waitqueue_head(&channel->playback_waitq);
> >  
> > -	if (audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg))
> > +	ret = audio_set_hw_params(&channel->pcm_hardware, pcm_format, cfg);
> > +	if (ret)
> >  		goto err_free_card;
> >  
> >  	snprintf(card->driver, sizeof(card->driver), "%s", DRIVER_NAME);
> > 
>