linux-kernel - Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after soft remove event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160926115940.GB5016@twins.programming.kicks-ass.net>
Date:   Mon, 26 Sep 2016 13:59:40 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Prarit Bhargava <prarit@...hat.com>
Cc:     Borislav Petkov <bp@...e.de>, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Len Brown <len.brown@...el.com>,
        Andi Kleen <ak@...ux.intel.com>, Jiri Olsa <jolsa@...hat.com>,
        Juergen Gross <jgross@...e.com>
Subject: Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after
 soft remove event

On Mon, Sep 26, 2016 at 07:45:37AM -0400, Prarit Bhargava wrote:
> > But then code which reads those will have to *know* that those cores are
> > offline - otherwise it would be confused by what it is reading there.
> 
> When offline, /sys/devices/system/cpuX/cpu/online is 0.  The problem is that
> when online is 0, topology disappears so there is no way to determine _the
> location_ of the offline'd thread.

As far as all that code is concerned, that CPU doesn't even have a
location anymore.

While there might be some distinction between hotplug and physical
hotplug on the user API side (I really wouldn't know), there isn't on
the kernel side.

Once you unplug a CPU, its _gone_. There isn't another hotplug operation
once you really take the CPU out.

Offline means out gone, vamoosh.

And it doesn't make sense to talk about the location of a resource
that's not there.