linux-kernel - Re: [RESEND PATCH] ACPI: CPPC: Support PCC with interrupt flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2457650.luWgNvV3g9@vostro.rjw.lan>
Date:   Mon, 26 Sep 2016 14:56:02 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Hoan Tran <hotran@....com>
Cc:     Len Brown <lenb@...nel.org>, pprakash@...eaurora.org,
        Ashwin Chaugule <ashwin.chaugule@...aro.org>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        lho@....com, Duc Dang <dhdang@....com>
Subject: Re: [RESEND PATCH] ACPI: CPPC: Support PCC with interrupt flag

On Wednesday, September 14, 2016 10:54:58 AM Hoan Tran wrote:
> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
> function to notify the mailbox framework about TX completion.
> 
> Signed-off-by: Hoan Tran <hotran@....com>
> Reviewed-by: Prashanth Prakash <pprakash@...eaurora.org>
> ---
>  drivers/acpi/cppc_acpi.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 3d1ae6d..d0d0504 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -311,7 +311,10 @@ static int send_pcc_cmd(u16 cmd)
>  	if (pcc_data.pcc_mrtt)
>  		last_cmd_cmpl_time = ktime_get();
>  
> -	mbox_client_txdone(pcc_data.pcc_channel, ret);
> +	if (pcc_data.pcc_channel->mbox->txdone_irq)
> +		mbox_chan_txdone(pcc_data.pcc_channel, ret);
> +	else
> +		mbox_client_txdone(pcc_data.pcc_channel, ret);
>  
>  end:
>  	if (cmd == CMD_WRITE) {
> 

Applied.

Thanks,
Rafael