linux-kernel - Re: [PATCH 0/2] NFS: Use complete() instead complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ded5c166-aa7e-ce61-8190-ffc15c7d1b12@Netapp.com>
Date:   Mon, 26 Sep 2016 09:31:54 -0400
From:   Anna Schumaker <Anna.Schumaker@...app.com>
To:     Daniel Wagner <daniel.wagner@...-carit.de>,
        Daniel Wagner <wagi@...om.org>, <linux-nfs@...r.kernel.org>
CC:     Trond Myklebust <trond.myklebust@...marydata.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/2] NFS: Use complete() instead complete_all()

On 09/26/2016 01:33 AM, Daniel Wagner wrote:
> Hi Anna,
> 
> On 09/23/2016 03:48 PM, Anna Schumaker wrote:
>>> Besides trying to analys all the code paths to the wait_for_completion()
>>> call and convince myself that there is only one waiter, I also run
>>> a few tests:
>>>
>>>  - some fio benchmarks
>>>  - pynfs
>>>   -cthon04
>>
>> Thanks for the patches, and for the extensive testing!  I haven't
>> tried them with xfstests yet, but They look okay to me otherwise.
>> Assuming I don't see any new failures there I'll plan on adding them
>> for v4.9.
> 
> I tried a few tests from xfstests but I was not sure which make sense to run, that's why I went for the more NFS specific tests.
> 
> I'll see what happens when I run the generic tests from xfstests. Should all of them pass?

No, there are a handful that we know don't pass.  When I run on NFS v4.1, I get:

        Failures: generic/035 generic/071 generic/128 generic/294 generic/306 generic/309 generic/310 generic/313 generic/314 generic/315 generic/316 generic/319 generic/337 generic/360 generic/375
        Failed 15 of 92 tests

Thanks,
Anna

> 
> cheers,
> daniel