linux-kernel - Re: [PATCH] scripts/recordmcount.c: account for .softirqentry.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160926110236.67f71572@grimm.local.home>
Date:   Mon, 26 Sep 2016 11:02:36 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Dmitry Vyukov <dvyukov@...gle.com>
Cc:     mingo@...hat.com, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, ryabinin.a.a@...il.com,
        surovegin@...gle.com, stable@...r.kernel.org
Subject: Re: [PATCH] scripts/recordmcount.c: account for .softirqentry.text

On Mon, 26 Sep 2016 11:13:15 +0200
Dmitry Vyukov <dvyukov@...gle.com> wrote:

> Commit "arch, ftrace: for KASAN put hard/soft IRQ entries into separate sections"
> added .softirqentry.text section, but it was not added to recordmcount.
> So functions in the section are untracable.
> Add the section to scripts/recordmcount.c.
> 
> Fixes: be7635e7287e ("arch, ftrace: for KASAN put hard/soft IRQ entries into separate sections")
> Cc: stable@...r.kernel.org # v4.6+
> Signed-off-by: Dmitry Vyukov <dvyukov@...gle.com>

I'm currently traveling and wont have time to process this any time
soon. But it looks good to me.

Acked-by: Steve Rostedt <rostedt@...dmis.org>

If someone else wants to pull this into their tree I'm fine with that.
It doesn't look like I would have to run this through my test suite.

I'm fine with the stable tag too.

-- Steve

> ---
>  scripts/recordmcount.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
> index 42396a7..a68f031 100644
> --- a/scripts/recordmcount.c
> +++ b/scripts/recordmcount.c
> @@ -363,6 +363,7 @@ is_mcounted_section_name(char const *const txtname)
>  		strcmp(".sched.text",    txtname) == 0 ||
>  		strcmp(".spinlock.text", txtname) == 0 ||
>  		strcmp(".irqentry.text", txtname) == 0 ||
> +		strcmp(".softirqentry.text", txtname) == 0 ||
>  		strcmp(".kprobes.text", txtname) == 0 ||
>  		strcmp(".text.unlikely", txtname) == 0;
>  }