linux-kernel - Re: [PATCH] drm/i2c: mark tda998x_audio_digital

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 26 Sep 2016 16:17:52 +0100
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     airlied@...ux.ie, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, arnd@...db.de, xie.baoyou@....com.cn,
        han.fei@....comm.cn, tang.qiang007@....com.cn
Subject: Re: [PATCH] drm/i2c: mark tda998x_audio_digital_mute() static

On Sun, Sep 25, 2016 at 03:59:19PM +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes]
> 
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/gpu/drm/i2c/tda998x_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
> index 9798d40..8bf6611 100644
> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> @@ -1289,7 +1289,7 @@ static void tda998x_audio_shutdown(struct device *dev, void *data)
>  	mutex_unlock(&priv->audio_mutex);
>  }
>  
> -int tda998x_audio_digital_mute(struct device *dev, void *data, bool enable)
> +static int tda998x_audio_digital_mute(struct device *dev, void *data, bool enable)

This causes the line to violate the coding style.  Please place
"bool enable" on the following line, thanks.

>  {
>  	struct tda998x_priv *priv = dev_get_drvdata(dev);
>  
> -- 
> 2.7.4
> 

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.