linux-kernel - Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <978710766.77328.1474912204420.JavaMail.zimbra@redhat.com>
Date:   Mon, 26 Sep 2016 13:50:04 -0400 (EDT)
From:   Jan Stancek <jstancek@...hat.com>
To:     Marcelo Cerri <marcelo.cerri@...onical.com>
Cc:     rui y wang <rui.y.wang@...el.com>, herbert@...dor.apana.org.au,
        mhcerri@...ux.vnet.ibm.com, leosilva@...ux.vnet.ibm.com,
        pfsmorigo@...ux.vnet.ibm.com, linux-crypto@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7




----- Original Message -----
> From: "Marcelo Cerri" <marcelo.cerri@...onical.com>
> To: "Jan Stancek" <jstancek@...hat.com>
> Cc: "rui y wang" <rui.y.wang@...el.com>, herbert@...dor.apana.org.au, mhcerri@...ux.vnet.ibm.com,
> leosilva@...ux.vnet.ibm.com, pfsmorigo@...ux.vnet.ibm.com, linux-crypto@...r.kernel.org,
> linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
> Sent: Monday, 26 September, 2016 4:15:10 PM
> Subject: Re: [bug] crypto/vmx/p8_ghash memory corruption in 4.8-rc7
> 
> Hi Jan,
> 
> Just out of curiosity, have you tried to use "76" on both values to
> check if the problem still happens?

I did, I haven't seen any panics with such patch:

@@ -211,7 +212,7 @@ struct shash_alg p8_ghash_alg = {
        .update = p8_ghash_update,
        .final = p8_ghash_final,
        .setkey = p8_ghash_setkey,
-       .descsize = sizeof(struct p8_ghash_desc_ctx),
+       .descsize = sizeof(struct p8_ghash_desc_ctx) + 20,
        .base = {
                 .cra_name = "ghash",
                 .cra_driver_name = "p8_ghash",