linux-kernel - Re: [lustre-devel] [PATCH] staging/lustre/obdclass: add missing header dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.20.1609261924400.5573@casper.infradead.org>
Date:   Mon, 26 Sep 2016 19:25:32 +0100 (BST)
From:   James Simmons <jsimmons@...radead.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>
cc:     oleg.drokin@...el.com, andreas.dilger@...el.com,
        gregkh@...uxfoundation.org, mhocko@...e.com,
        james.a.nunez@...el.com, uja.ornl@...oo.com, arnd@...db.de,
        kirill.shutemov@...ux.intel.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, xie.baoyou@....com.cn,
        lustre-devel@...ts.lustre.org
Subject: Re: [lustre-devel] [PATCH] staging/lustre/obdclass: add missing
 header dependencies


> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:157:5: warning: no previous prototype for 'obd_sysctl_init' [-Wmissing-prototypes]
> 
> In fact, this function is declared in ../../include/obd_class.h,
> so this patch add missing header dependencies.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

Reviewed-by: James Simmons <jsimmons@...radead.org>

> ---
>  drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
> index 8f70dd2..2daa834 100644
> --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
> +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
> @@ -45,6 +45,7 @@
>  
>  #include "../../include/obd_support.h"
>  #include "../../include/lprocfs_status.h"
> +#include "../../include/obd_class.h"
>  
>  struct static_lustre_uintvalue_attr {
>  	struct {
> -- 
> 2.7.4
> 
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@...ts.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
>