linux-kernel - Re: [PATCH][V2] cxgb4: fix -ve error check on a signed iq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160925.234012.933201102491235169.davem@davemloft.net>
Date:   Sun, 25 Sep 2016 23:40:12 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     hariprasad@...lsio.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] cxgb4: fix -ve error check on a signed iq

From: Colin King <colin.king@...onical.com>
Date: Sun, 25 Sep 2016 14:14:45 -0700

> From: Colin Ian King <colin.king@...onical.com>
> 
> iq is unsigned, so the error check for iq < 0 has no effect so errors
> can slip past this check.  Fix this by making iq signed and also
> get_filter_steerq return a signed int so a -ve error can be returned.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks.